[
https://issues.apache.org/jira/browse/ZOOKEEPER-2194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14573021#comment-14573021
]
Chris Nauroth commented on ZOOKEEPER-2194:
------------------------------------------
Hi [~mitake].
At this point, you'll need to wait for a committer to code review it. The
committer will either reply with additional feedback or say +1 and commit it to
the repository. It looks like most of the committers are busy right now
reviewing a new feature, ZOOKEEPER-2163 (container znodes), so it might take a
while for someone to get to this. If you don't hear anything more on this
issue in a few weeks, then I recommend sending a reminder note to
[email protected] asking for a committer to code review.
> Let DataNode.getChildren() return an unmodifiable view of its children set
> --------------------------------------------------------------------------
>
> Key: ZOOKEEPER-2194
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2194
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
> Reporter: Hitoshi Mitake
> Assignee: Hitoshi Mitake
> Priority: Trivial
> Attachments: ZOOKEEPER-2194-v2.patch, ZOOKEEPER-2194.patch
>
>
> Current DataNode.getChildren() directly returns a pointer of its private
> member, children. However, the member should be modified through addChild()
> and removeChild(). Callers of getChildren() shouldn't modify it directly.
> For preventing the direct modification by the callers, this patch lets
> getChildren() return an unmodifiable view of its children set. If the callers
> try to modify directly, runtime exception will be risen.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
