[
https://issues.apache.org/jira/browse/ZOOKEEPER-2206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14574981#comment-14574981
]
Hadoop QA commented on ZOOKEEPER-2206:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12737496/ZOOKEEPER-2206.patch
against trunk revision 1683605.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2755//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2755//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2755//console
This message is automatically generated.
> Add missing packet types to LearnerHandler.packetToString()
> -----------------------------------------------------------
>
> Key: ZOOKEEPER-2206
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2206
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
> Affects Versions: 3.5.0
> Reporter: Hitoshi Mitake
> Assignee: Hitoshi Mitake
> Priority: Trivial
> Fix For: 3.5.1, 3.6.0
>
> Attachments: ZOOKEEPER-2206.patch
>
>
> packetToString() is a method which is suitable for obtaining string
> representation of QuorumPacket. But it lacks some types of QuorumPacket. This
> patch adds the missing types and enhance the method for more friendly logging.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
