[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14588539#comment-14588539
 ] 

Hadoop QA commented on ZOOKEEPER-2095:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12688324/ZOOKEEPER-2095.patch
  against trunk revision 1685685.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified 
tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 2.0.3) 
warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2772//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2772//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2772//console

This message is automatically generated.

> Add Systemd startup/conf files
> ------------------------------
>
>                 Key: ZOOKEEPER-2095
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2095
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: contrib
>            Reporter: Guillaume ALAUX
>            Priority: Minor
>         Attachments: ZOOKEEPER-2095.patch
>
>
> As adoption of systemd by distributions grows, it would be nice to have 
> systemd configuration and startup files for Zookeeper in the upstream tree. I 
> would thus like to contribute the following patch which brings the followings 
> systemd files:
> - {{sysusers.d_zookeeper.conf}}: creates {{zookeeper}} Linux system user to 
> run Zookeeper
> - {{tmpfiles.d_zookeeper.conf}}: creates temporary {{/var/log/zookeeper}} and 
> {{/var/lib/zookeeper} directories
> - {{zookeeper.service}}: regular systemd startup _script_
> - {{[email protected]}}: systemd startup _script_ for specific use (for 
> instance when Zookeeper is invoked to support some other piece of software – 
> [example for 
> Kafka|http://pkgbuild.com/git/aur-mirror.git/tree/kafka/systemd_kafka.service#n3],
>  [example for 
> Storm|http://pkgbuild.com/git/aur-mirror.git/tree/storm/systemd_storm-nimbus.service#n3])



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to