[
https://issues.apache.org/jira/browse/ZOOKEEPER-2224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14609607#comment-14609607
]
Rakesh R commented on ZOOKEEPER-2224:
-------------------------------------
Thanks [~arshad.mohammad] for the contribution. Few minor comments, please see:
# small typo: DEFAUL_SOCKET_TIMEOUTE, please remove extra E
# In general, it is good to follow the pattern - begin the test case name with
{{test}}. Please rename the test name as {{testValidateSocketTimeout}}. Also,
please add {{@Test(timeout=10000)}} in test.
{code}
public void validateSocketTimeoute()
{code}
# Its good to add exception message when wrapping the actual exception like,
{code}
throw new IOException("Exception while executing four letter word: " + cmd, e);
{code}
> Four letter command hangs when network is slow
> ----------------------------------------------
>
> Key: ZOOKEEPER-2224
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2224
> Project: ZooKeeper
> Issue Type: Bug
> Reporter: Arshad Mohammad
> Assignee: Arshad Mohammad
> Priority: Minor
> Fix For: 3.6.0
>
> Attachments: ZOOKEEPER-2224-01.patch, ZOOKEEPER-2224-02.patch
>
>
> Four letter command hangs when network is slow or network goes down in
> between the operation, and the application also, which calling this four
> letter command, hangs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
