[
https://issues.apache.org/jira/browse/ZOOKEEPER-2209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14638494#comment-14638494
]
Hadoop QA commented on ZOOKEEPER-2209:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12746746/ZooKeeperNetEx.snk
against trunk revision 1690207.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
-1 patch. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2813//console
This message is automatically generated.
> A .NET C# version of ZooKeeper client 3.4.6 release
> ---------------------------------------------------
>
> Key: ZOOKEEPER-2209
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2209
> Project: ZooKeeper
> Issue Type: New Feature
> Affects Versions: 3.4.6
> Environment: .NET CoreCLR
> Reporter: Shay Hazor
> Assignee: Shay Hazor
> Labels: .NET, CoreCLR, async, c#
> Fix For: 3.4.6
>
> Attachments: ZOOKEEPER-2209.patch, ZooKeeperNetEx.snk
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> Inspired by the work of ewhauser .
> I propose a C# Client that supports the current stable version of ZK 3.4.6.
> It was built by using static code conversion tools followed by manual editing
> and C# implementations of java selector and other java constructs.
> A great measure was taken to follow the logic of the java version. In fact,
> the code is almost identical. Thus allowing easy evolution alongside the java
> version.
> Main features:
> * fully .NET async, not explicit threads used
> * all relevant unit tests have been converted and passing consistently
> * recipes are included, will be converted to async soon
> * Code is 100% CoreCLR compliant
> * NuGet package -
> [ZooKeeperNetEx|https://www.nuget.org/packages/ZooKeeperNetEx] is already
> integrated in [Microsoft Project Orleans|https://github.com/dotnet/orleans]
> as the only open-source membership provider.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)