[
https://issues.apache.org/jira/browse/ZOOKEEPER-2239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14658764#comment-14658764
]
Hadoop QA commented on ZOOKEEPER-2239:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12748705/ZOOKEEPER-2239.patch
against trunk revision 1692989.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2818//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2818//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2818//console
This message is automatically generated.
> JMX State from LocalPeerBean Incorrect
> --------------------------------------
>
> Key: ZOOKEEPER-2239
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2239
> Project: ZooKeeper
> Issue Type: Bug
> Components: jmx
> Affects Versions: 3.4.6, 3.5.0, 3.5.1
> Environment: All
> Reporter: Kevin Lee
> Fix For: 3.4.7, 3.5.2, 3.6.0
>
> Attachments: ZOOKEEPER-2239.patch
>
>
> The "State" property of LocalPeerBean in package
> org.apache.zookeeper.server.quorum is returning the incorrect value. It is
> performing peer.getState() which is calling the getState() method on
> java.lang.Thread instead of getting the server state from
> org.apache.zookeeper.server.quorum.QuorumPeer. The Javadoc within
> LocalPeerMXBean.java states that it should be returning the server state as
> well. The fix is to call peer.getServerState() in the getState() method of
> LocalPeerBean instead of peer.getState().toString(). This will return the
> states defined in QuorumStats.Provider (unknown, leaderelection, leading,
> following, and observing). This issue prevents JMX monitoring of the
> Zookeeper server state.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
