[
https://issues.apache.org/jira/browse/ZOOKEEPER-2264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723471#comment-14723471
]
Hadoop QA commented on ZOOKEEPER-2264:
--------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12753289/ZOOKEEPER-2264-01.patch
against trunk revision 1698058.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 2 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2852//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2852//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2852//console
This message is automatically generated.
> Wrong error message when secureClientPortAddress is configured but
> secureClientPort is not configured
> ------------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-2264
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2264
> Project: ZooKeeper
> Issue Type: Bug
> Reporter: Arshad Mohammad
> Assignee: Arshad Mohammad
> Priority: Minor
> Fix For: 3.5.1
>
> Attachments: ZOOKEEPER-2264-01.patch
>
>
> # Wrong error message when secureClientPortAddress is configured but
> secureClientPort is not configured.
> zookeeper throws IllegalArgumentException with error message
> {{clientPortAddress is set but clientPort is not set}} but should be
> {{secureClientPortAddress is set but secureClientPort is not set}}
> # There is another problem with the same code.
> value is assigned to local variable but null check is done on instance
> variable so we will never get error message for this scenario.
> {code}if (this.secureClientPortAddress != null) {{code}
> should be replaced with
> {code}if (secureClientPortAddress != null) {{code}
> # Above problem is there for clientPort scenario also. So we should replace
> {code}if (this.clientPortAddress != null) {{code}
> with
> {code}if (clientPortAddress != null) {{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
