[
https://issues.apache.org/jira/browse/ZOOKEEPER-2238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14876485#comment-14876485
]
Edward Ribeiro commented on ZOOKEEPER-2238:
-------------------------------------------
Thanks for the review [~arshad.mohammad]!
I am following the same principle of {{maxClientCnxns}}, so to keep the
consistency -- both maxCnxns and maxClientCnxns are intimally related --, I
followed along adding the parameter. I don't agree that this loose focus
because it defines a clear path of calling instead of having a class high down
the call path calling system.property while {{maxClientCnxns}} is explictly
passed. This would be weird, imo.
Also, if I remember well, {{maxClientCnxns}} doesn't use system property, does
it? The only method signatures I changed were the ones already calling
{{maxClientCnxns}}. But I am open to change it to use system.property,
specially if {{maxClientCnxns}} is also changed, but this would require change
as much constructors as my patch, no?
> Support limiting the maximum number of connections/clients to a zookeeper
> server.
> ---------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-2238
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2238
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: nijel
> Assignee: Edward Ribeiro
> Attachments: ZOOKEEPER-2238.2.patch, ZOOKEEPER-2238.diff
>
>
> Currently zookeeper have the feature of limiting the maximum number of
> connection/client per IP or Host (maxClientCnxns).
> But to safe guard zookeeper server from DoS attack due to many clients from
> different IPs, it is better to have a limit of total number of
> connections/clients to a a single member of the ZooKeeper ensemble as well.
> So the idea is to introduce a new configuration to limit the maximum number
> of total connections/clients.
> Please share your thoughts.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
