[
https://issues.apache.org/jira/browse/ZOOKEEPER-2211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arshad Mohammad updated ZOOKEEPER-2211:
---------------------------------------
Attachment: ZOOKEEPER-2211-04.patch
Thanks [~rgs] for your comments.
# Handled NumberFormatException
# Added file exist validation for snap and log directory
# Apart from args following things also are different
## comments
## snapshot creation directory
## assertion
I think if extracted to a method it will increase the code complexity, code
will be less understandable. at least four places need to add if else. So not
changing
is it ok?
Submitting patch ZOOKEEPER-2211-04.patch
> PurgeTxnLog does not correctly purge when snapshots and logs are at different
> locations
> ---------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-2211
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2211
> Project: ZooKeeper
> Issue Type: Bug
> Components: scripts
> Affects Versions: 3.4.6, 3.5.0
> Environment: Ubuntu 12.04, Java 1.7.
> Reporter: Wesley Chow
> Assignee: Arshad Mohammad
> Fix For: 3.4.7, 3.5.2, 3.6.0
>
> Attachments: ZOOKEEPER-2211-02.patch, ZOOKEEPER-2211-03.patch,
> ZOOKEEPER-2211-04.patch, ZOOKEEPER-2211.patch
>
>
> PurgeTxnLog does not work when snapshots and transaction logs are at
> different file paths. The argument handling is buggy and only works when both
> snap and datalog dirs are given, and datalog dir contains both logs and snaps
> (snap is ignored).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)