[
https://issues.apache.org/jira/browse/ZOOKEEPER-2290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14952683#comment-14952683
]
Edward Ribeiro commented on ZOOKEEPER-2290:
-------------------------------------------
Some further review comments:
1. {{Rate}}'s {{public void inc(final int incr)}} is defined, but not used,
right? If so, no need to include it.
2. If {{getRate}} is the rate per __second__, why are you using time slots of
10,000 ms?
> Add read/write qps metrics in monitor cmd
> -----------------------------------------
>
> Key: ZOOKEEPER-2290
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2290
> Project: ZooKeeper
> Issue Type: Improvement
> Affects Versions: 3.4.6
> Reporter: Liu Shaohui
> Priority: Minor
> Labels: monitor
> Fix For: 3.6.0
>
> Attachments: ZOOKEEPER-2290-v1.patch
>
>
> Read/write qps are important metrics to show the pressure of the cluster. We
> can also use it to alert about some abuse of zookeeper.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
