[
https://issues.apache.org/jira/browse/ZOOKEEPER-2290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Liu Shaohui updated ZOOKEEPER-2290:
-----------------------------------
Attachment: ZOOKEEPER-2290-v2.patch
Update for [~eribeiro]'s review
{quote}
1/2/3/4/6
{quote}
All done
{quote}
1. Rate's public void inc(final int incr) is defined, but not used, right? If
so, no need to include it.
{quote}
Removed.
{quote}
2. If getRate is the rate per _second_, why are you using time slots of 10,000
ms?
{quote}.
The average of 10,000 ms may be more representative than that in 1000ms. But
never mind, and just revert it 1000 ms.
Thanks very much for your so careful review~
> Add read/write qps metrics in monitor cmd
> -----------------------------------------
>
> Key: ZOOKEEPER-2290
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2290
> Project: ZooKeeper
> Issue Type: Improvement
> Affects Versions: 3.4.6
> Reporter: Liu Shaohui
> Priority: Minor
> Labels: monitor
> Fix For: 3.6.0
>
> Attachments: ZOOKEEPER-2290-v1.patch, ZOOKEEPER-2290-v2.patch
>
>
> Read/write qps are important metrics to show the pressure of the cluster. We
> can also use it to alert about some abuse of zookeeper.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
