[ https://issues.apache.org/jira/browse/ZOOKEEPER-2299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14969517#comment-14969517 ]
Edward Ribeiro commented on ZOOKEEPER-2299: ------------------------------------------- Oops, hit enter before finishing the text. So, {{testClientAddress}} is a very generic name, probably very similar to other similar/equal names around. I think a more appropriate test name would be {{testClientAddressShouldNotBeNull}} or something alike, up to you. :) I am fond of Uncle Bob Martin recommendation that test methods should be named the more clearly as possible and the places I worked enforced this too. ;) You can see some traditional recommendations here: https://dzone.com/articles/7-popular-unit-test-naming > NullPointerException in LocalPeerBean for ClientAddress > ------------------------------------------------------- > > Key: ZOOKEEPER-2299 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2299 > Project: ZooKeeper > Issue Type: Bug > Components: jmx > Reporter: Arshad Mohammad > Assignee: Arshad Mohammad > Fix For: 3.5.2 > > Attachments: ZOOKEEPER-2299-01.patch > > > When clientPortAddress is not configured LocalPeerBean throws > NullPointerException. > *Expected Behavior:* > # When only clientPort is configured ClientAddress value should be > 0.0.0.0:clientPort or 0:0:0:0:0:0:0:0:clientPort > # When both clientPort clientPortAddress are configured then expected value > is clientPortAddress:clientPort -- This message was sent by Atlassian JIRA (v6.3.4#6332)