[
https://issues.apache.org/jira/browse/ZOOKEEPER-2184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14970999#comment-14970999
]
Flavio Junqueira commented on ZOOKEEPER-2184:
---------------------------------------------
Hi [~rthille], Thanks for the patch. I have a few comments and concerns about
this patch:
# I think it would be better to not track connectedSinceNext and try to resolve
addresses again after spinning over the list of servers, perhaps right after
where we do a Thread.sleep(spinDelay), line 111 after applying your patch.
# I'm not sure why you deleted that block of code in the constructor of
StaticHostProvider.
# The change in ZxidRolloverTest.java doesn't seem to be part of this patch.
> Zookeeper Client should re-resolve hosts when connection attempts fail
> ----------------------------------------------------------------------
>
> Key: ZOOKEEPER-2184
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2184
> Project: ZooKeeper
> Issue Type: Bug
> Components: java client
> Affects Versions: 3.4.6, 3.5.0
> Environment: Ubuntu 14.04 host, Docker containers for Zookeeper &
> Kafka
> Reporter: Robert P. Thille
> Assignee: Robert P. Thille
> Labels: easyfix, patch
> Fix For: 3.4.7, 3.5.2
>
> Attachments: ZOOKEEPER-2184.patch
>
>
> Testing in a Docker environment with a single Kafka instance using a single
> Zookeeper instance. Restarting the Zookeeper container will cause it to
> receive a new IP address. Kafka will never be able to reconnect to Zookeeper
> and will hang indefinitely. Updating DNS or /etc/hosts with the new IP
> address will not help the client to reconnect as the
> zookeeper/client/StaticHostProvider resolves the connection string hosts at
> creation time and never re-resolves.
> A solution would be for the client to notice that connection attempts fail
> and attempt to re-resolve the hostnames in the connectString.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
