[
https://issues.apache.org/jira/browse/ZOOKEEPER-1029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14981415#comment-14981415
]
Flavio Junqueira edited comment on ZOOKEEPER-1029 at 10/29/15 10:09 PM:
------------------------------------------------------------------------
We have these test cases:
{code}
void testInvalidAddressString1()
{
const string INVALID_HOST("host1");
zh=zookeeper_init(INVALID_HOST.c_str(),0,0,0,0,0);
CPPUNIT_ASSERT(zh==0);
CPPUNIT_ASSERT_EQUAL(EINVAL,errno);
}
void testInvalidAddressString2()
{
const string INVALID_HOST("host1:1111+host:123");
zh=zookeeper_init(INVALID_HOST.c_str(),0,0,0,0,0);
CPPUNIT_ASSERT(zh==0);
CPPUNIT_ASSERT((ENOENT|EINVAL) & errno);
}
{code}
Why isn't this verifying the problem described here? CC [~dheerajagrawal]
was (Author: fpj):
We have these test cases:
{code}
void testInvalidAddressString1()
{
const string INVALID_HOST("host1");
zh=zookeeper_init(INVALID_HOST.c_str(),0,0,0,0,0);
CPPUNIT_ASSERT(zh==0);
CPPUNIT_ASSERT_EQUAL(EINVAL,errno);
}
void testInvalidAddressString2()
{
const string INVALID_HOST("host1:1111+host:123");
zh=zookeeper_init(INVALID_HOST.c_str(),0,0,0,0,0);
CPPUNIT_ASSERT(zh==0);
CPPUNIT_ASSERT((ENOENT|EINVAL) & errno);
}
{code}
Why isn't this verifying the problem described here?
> C client bug in zookeeper_init (if bad hostname is given)
> ---------------------------------------------------------
>
> Key: ZOOKEEPER-1029
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1029
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.3.2, 3.4.6, 3.5.0
> Reporter: Dheeraj Agrawal
> Assignee: Flavio Junqueira
> Priority: Blocker
> Fix For: 3.4.7, 3.5.2
>
> Attachments: ZOOKEEPER-1029-3.4.patch, ZOOKEEPER-1029-3.4.patch
>
>
> If you give invalid hostname to zookeeper_init method, it's not able to
> resolve it, and it tries to do the cleanup (free buffer/completion lists/etc)
> . The adaptor_init() is not called for this code path, so the lock,cond
> variables (for adaptor, completion lists) are not initialized.
> As part of the cleanup it's trying to clean up some buffers and acquires
> locks and unlocks (where the locks have not yet been initialized, so
> unlocking fails)
> lock_completion_list(&zh->sent_requests); - pthread_mutex/cond not
> initialized
> tmp_list = zh->sent_requests;
> zh->sent_requests.head = 0;
> zh->sent_requests.last = 0;
> unlock_completion_list(&zh->sent_requests); trying to broadcast here
> on uninitialized cond
> It should do error checking to see if locking succeeds before unlocking it.
> If Locking fails, then appropriate error handling has to be done.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
