[ https://issues.apache.org/jira/browse/ZOOKEEPER-2142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14984179#comment-14984179 ]
Michi Mutsuzaki commented on ZOOKEEPER-2142: -------------------------------------------- Sorry I'm jumping in late. The original patch ZOOKEEPER-2142 looks fine to me because it adds a new constructor to pass the name as the parameter, so classes that extend from ZooKeeperServerBean shouldn't need to implement getName() method. I'd refactor other classes (LeaderBean, FollowerBean) to use the new constructor and pass their names as well ("Leader" and "Follower") and get rid of getName() method from these classes. > JMX ObjectName is incorrect for observers > ----------------------------------------- > > Key: ZOOKEEPER-2142 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2142 > Project: ZooKeeper > Issue Type: Bug > Affects Versions: 3.4.6, 3.5.1 > Reporter: Karol Dudzinski > Assignee: Edward Ribeiro > Priority: Trivial > Fix For: 3.4.7, 3.5.2, 3.6.0 > > Attachments: ZOOKEEPER-2142, ZOOKEEPER-2142.2.patch > > > Observers show up in JMX as StandaloneServer rather than Observer. -- This message was sent by Atlassian JIRA (v6.3.4#6332)