[
https://issues.apache.org/jira/browse/ZOOKEEPER-2326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15012241#comment-15012241
]
Hadoop QA commented on ZOOKEEPER-2326:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12773100/ZOOKEEPER-2326-01.patch
against trunk revision 1713774.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
-1 javadoc. The javadoc tool appears to have generated 1 warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2958//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2958//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2958//console
This message is automatically generated.
> Include connected server address:port in log
> --------------------------------------------
>
> Key: ZOOKEEPER-2326
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2326
> Project: ZooKeeper
> Issue Type: Improvement
> Components: java client
> Reporter: Arshad Mohammad
> Assignee: Arshad Mohammad
> Priority: Minor
> Fix For: 3.5.2
>
> Attachments: ZOOKEEPER-2326-01.patch
>
>
> Currently ZooKeeper client log contains blank myid as bellow
> {noformat}
> 2015-11-18 23:46:39,045 [myid:] - INFO
> [main-SendThread(192.168.1.3:2183):ClientCnxn$SendThread@1138] - Opening
> socket connection to server 192.168.1.3/192.168.1.3:2183. Will attempt to
> SASL-authenticate using Login Context section 'Client'
> 2015-11-18 23:46:40,387 [myid:] - WARN
> [main-SendThread(192.168.1.3:2183):ClientCnxn$SendThread@1206] - Client
> session timed out, have not heard from server in 1499ms for sessionid
> 0x200009eb6510002
> 2015-11-18 23:46:40,387 [myid:] - INFO
> [main-SendThread(192.168.1.3:2183):ClientCnxn$SendThread@1254] - Client
> session timed out, have not heard from server in 1499ms for sessionid
> 0x200009eb6510002, closing socket connection and attempting reconnect
> 2015-11-18 23:46:41,323 [myid:] - INFO
> [main-SendThread(192.168.1.3:2181):ZooKeeperSaslClient@235] - Client will use
> DIGEST-MD5 as SASL mechanism.
> {noformat}
> myid is blank. it is fine as at client side myid(serverid ) does not make any
> sense. But we can assign myid serverIP: port which will be a very helpful
> information in analysing the issues. So we after fix we can have log as bellow
> {noformat}
> 2015-11-19 03:51:27,254 [myid:192.168.1.3:2183] - INFO
> [main-SendThread(192.168.1.3:2183):Login@290] - successfully logged in.
> 2015-11-19 03:51:27,270 [myid:192.168.1.3:2183] - INFO
> [Thread-0:Login$1@124] - TGT refresh thread started.
> 2015-11-19 03:51:27,270 [myid:192.168.1.3:2183] - INFO
> [main-SendThread(192.168.1.3:2183):ZooKeeperSaslClient$1@297] - Client will
> use GSSAPI as SASL mechanism.
> 2015-11-19 03:51:27,270 [myid:192.168.1.3:2183] - INFO [Thread-0:Login@298]
> - TGT valid starting at: Thu Nov 19 03:51:27 IST 2015
> 2015-11-19 03:51:27,270 [myid:192.168.1.3:2183] - INFO [Thread-0:Login@299]
> - TGT expires: Thu Nov 19 03:53:27 IST 2015
> 2015-11-19 03:51:27,270 [myid:192.168.1.3:2183] - INFO
> [Thread-0:Login$1@178] - TGT refresh sleeping until: Thu Nov 19 03:53:05 IST
> 2015
> 2015-11-19 03:51:27,285 [myid:192.168.1.3:2183] - INFO
> [main-SendThread(192.168.1.3:2183):ClientCnxn$SendThread@1141] - Opening
> socket connection to server 192.168.1.3/192.168.1.3:2183. Will attempt to
> SASL-authenticate using Login Context section 'Client'
> 2015-11-19 03:51:27,301 [myid:192.168.1.3:2183] - INFO
> [main-SendThread(192.168.1.3:2183):ClientCnxn$SendThread@981] - Socket
> connection established, initiating session, client: /192.168.1.2:53117,
> server: 192.168.1.3/192.168.1.3:2183
> 2015-11-19 03:51:28,632 [myid:192.168.1.3:2183] - WARN
> [main-SendThread(192.168.1.3:2183):ClientCnxn$SendThread@1209] - Client
> session timed out, have not heard from server in 1333ms for sessionid 0x0
> 2015-11-19 03:51:28,632 [myid:192.168.1.3:2183] - INFO
> [main-SendThread(192.168.1.3:2183):ClientCnxn$SendThread@1257] - Client
> session timed out, have not heard from server in 1333ms for sessionid 0x0,
> closing socket connection and attempting reconnect
> 2015-11-19 03:51:29,147 [myid:192.168.1.3:2181] - INFO
> [main-SendThread(192.168.1.3:2181):ZooKeeperSaslClient$1@297] - Client will
> use GSSAPI as SASL mechanism.
> 2015-11-19 03:51:29,152 [myid:192.168.1.3:2181] - INFO
> [main-SendThread(192.168.1.3:2181):ClientCnxn$SendThread@1141] - Opening
> socket connection to server 192.168.1.3/192.168.1.3:2181. Will attempt to
> SASL-authenticate using Login Context section 'Client'
> 2015-11-19 03:51:29,154 [myid:192.168.1.3:2181] - INFO
> [main-SendThread(192.168.1.3:2181):ClientCnxn$SendThread@981] - Socket
> connection established, initiating session, client: /192.168.1.2:53118,
> server: 192.168.1.3/192.168.1.3:2181
> 2015-11-19 03:51:30,487 [myid:192.168.1.3:2181] - WARN
> [main-SendThread(192.168.1.3:2181):ClientCnxn$SendThread@1209] - Client
> session timed out, have not heard from server in 1333ms for sessionid 0x0
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
