I should note also that I have looked closely at the issue tracker (e.g., https://issues.apache.org/jira/browse/ZOOKEEPER-1953) and various related changesets (e.g., http://svn.apache.org/viewvc?view=revision&revision=1148116) but being young and raised mostly on git I could not find a discussion of why this file is the way that it is. So it could well be that I am simply missing simple guidance like "make sure not to include `stdint.h` in any project consuming the ZK C client library."
On Thu, Jan 28, 2016 at 3:18 PM, Alex Clemmer <[email protected]> wrote: > Hey folks. > > We (the Apache Mesos project) are building against the ZK C client on > Windows, with VS 2015 (and MSVC v.1900). When we attempt a vanilla > build, including both `zookeeper.h` and `stdint.h` causes the compiler > to complain that we're re-typedef'ing a few types (such as > `int_fast8_t` with different underlying types) in the file, > `winstdint.h`. > > I have scoured the Internet to see if I'm missing a -D flag somewhere, > but it does not appear that this is the case. > > The comments in this file state that it's meant to provide a > C9X-compliant version of `stdint.h` for Windows, but for later > versions of MSVC some of the definitions seem to be redundant or > different. (For example, on VS 2013 `int_fast16_t` is redefined with a > different underlying type.) > > My question for you all is: am I missing something obvious, or should > I submit a bug and a patch to resolve this issue for you? > > > -- > Alex > > Theory is the first term in the Taylor series of practice. -- Thomas M > Cover (1992) -- Alex Theory is the first term in the Taylor series of practice. -- Thomas M Cover (1992)
