[
https://issues.apache.org/jira/browse/ZOOKEEPER-2255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15177016#comment-15177016
]
Hadoop QA commented on ZOOKEEPER-2255:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12751536/ZOOKEEPER-2255.patch
against trunk revision 1733348.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 99 new or modified tests.
-1 patch. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3066//console
This message is automatically generated.
> Use static member classes when permitted
> ----------------------------------------
>
> Key: ZOOKEEPER-2255
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2255
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: Yvonne Ironberg
> Assignee: Yvonne Ironberg
> Priority: Minor
> Attachments: ZOOKEEPER-2255.patch
>
>
> Using static member classes saves time and space because an instances of a
> nonstatic member class has a reference to its enclosing instance.
> Also did some style improvements:
> - JLS recommends modifiers be in this order: public protected private
> abstract static final transient volatile synchronized native strictfp.
> - Inserted some spaces.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
