[
https://issues.apache.org/jira/browse/ZOOKEEPER-2195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15180658#comment-15180658
]
Dmitry Ryabkov commented on ZOOKEEPER-2195:
-------------------------------------------
The Findbugs concern seems to be valid, but it is completely unrelated to my
change. It is in ZooKeeper client code in
org.apache.zookeeper.client.ZooKeeperSaslClient.
As for the tests, as I said when submitting the patch this is just a syntax
error fix, and it is in the code which is difficult to have tests for (static
filed with its value set by a static initializer) without some refactoring.
Refactoring this code for the sake of testing the fix for the property name
string value is possible for sure, but I felt like that'd be overkill.
> fsync.warningthresholdms in zoo.cfg not working
> -----------------------------------------------
>
> Key: ZOOKEEPER-2195
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2195
> Project: ZooKeeper
> Issue Type: Bug
> Components: quorum
> Affects Versions: 3.4.6, 3.5.0
> Reporter: David Fan
> Assignee: Biju Nair
> Priority: Trivial
> Attachments: ZOOKEEPER-2195.patch
>
>
> Config fsync.warningthresholdms in zoo.cfg does not work.
> I find QuorumPeerConfig.parseProperties give fsync.warningthresholdms a
> prefix like "zookeeper.fsync.warningthresholdms". But in class FileTxnLog
> where fsync.warningthresholdms is used, code is
> :Long.getLong("fsync.warningthresholdms", 1000),without prefix "zookeeper.",
> therefore can not get fsync.warningthresholdms's value.
> I wonder the speed of fsync, need this config to see whether the speed is
> good enough.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
