[
https://issues.apache.org/jira/browse/ZOOKEEPER-2393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15202980#comment-15202980
]
Hadoop QA commented on ZOOKEEPER-2393:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12794306/ZOOKEEPER-2393.patch
against trunk revision 1735646.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
-1 javadoc. The javadoc tool appears to have generated 100 warning
messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3109//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3109//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3109//console
This message is automatically generated.
> Revert run-time dependency on log4j and slf4j-log4j12
> -----------------------------------------------------
>
> Key: ZOOKEEPER-2393
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2393
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
> Reporter: Arshad Mohammad
> Assignee: Arshad Mohammad
> Priority: Blocker
> Fix For: 3.5.2, 3.6.0
>
> Attachments: ZOOKEEPER-2393.patch, ZOOKEEPER-2393.patch
>
>
> Zookeeper run-time dependency on log4j and slf4j-log4j12 was removed as part
> of ZOOKEEPER-1371 jira work.
> Following things were done as part of ZOOKEEPER-1371
> # Removed direct log4j API use from the code, instead used slf4j-api
> # Changed log4j and slf4j-log4j12 run time dependency to test time
> dependency
> # Upgraded log4j, slf4j-log4j12 and slf4j-api versions.
> Here is the component wise version change
> #* (zookeeper)ivy.xml
> log4j: 1.2.15 -->1.7.5
> #* src\contrib\loggraph\ivy.xml
> slf4j-api: 1.6.1 -->1.7.5
> slf4j-log4j12: 1.6.1 -->1.7.5
> log4j: 1.2.15 -->1.7.5
> #* src\contrib\rest\ivy.xml
> slf4j-api: 1.6.1 -->1.7.5
> slf4j-log4j12: 1.6.1 -->1.7.5
> log4j: 1.2.15 -->1.7.5
> #* src\contrib\zooinspector\ivy.xml
> slf4j-api: 1.6.1 -->1.7.5
> slf4j-log4j12: 1.6.1 -->1.7.5
> log4j: 1.2.15 -->1.7.5
> The major problem with ZOOKEEPER-1371 change is that it removed run time
> dependency. For more detail refer ZOOKEEPER-2342 discussion
> Now as part of this jira revert back only run time dependency, #2, on log4j
> and slf4j-log4j12.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
