[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15208313#comment-15208313
 ] 

Hadoop QA commented on ZOOKEEPER-2394:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  
http://issues.apache.org/jira/secure/attachment/12794984/ZOOKEEPER-2394-01.patch
  against trunk revision 1736259.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 2 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    -1 findbugs.  The patch appears to introduce 2 new Findbugs (version 2.0.3) 
warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3116//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3116//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3116//console

This message is automatically generated.

> Many ZooKeeper properties are not configurable in zoo.cfg
> ---------------------------------------------------------
>
>                 Key: ZOOKEEPER-2394
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2394
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: server
>            Reporter: Arshad Mohammad
>            Assignee: Arshad Mohammad
>             Fix For: 3.5.2
>
>         Attachments: ZOOKEEPER-2394-01.patch
>
>
> Many ZooKeeper properties are not configurable in zoo.cfg. If configured in 
> zoo.cfg, {{QuorumPeerConfig}} parse logic will pre append "zookeeper" which 
> is not the same property used in code. So a property with a name {{abc.xyz}} 
> becomes {{zookeeper.abc.xyz}}
> Bellow are properties which can not configured in zoo.cfg, can only be 
> configured using java system properties.
> # follower.nodelay
> # leader.nodelay
> # readonlymode.enabled
> # jute.maxbuffer
> # znode.container.checkIntervalMs
> # znode.container.maxPerMinute
> This jira targets to make these properties configurable in zoo.cfg as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to