[
https://issues.apache.org/jira/browse/ZOOKEEPER-2403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15211390#comment-15211390
]
Patrick Hunt commented on ZOOKEEPER-2403:
-----------------------------------------
If you're interesting in fixing this there are at least a few places that need
to also be addressed. Likely add a method to handle this, one that's backward
compatible. A test should verify b/w compat. It would also be good to update
the docs in src/docs to be more clear on valid values.
{noformat}
$ ag getProperty |egrep yes
src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java:124:
private final boolean forceSync = !System.getProperty("zookeeper.forceSync",
"yes").equals("no");;
src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java:96:
skipACL = System.getProperty("zookeeper.skipACL", "no").equals("yes");
src/java/main/org/apache/zookeeper/server/quorum/Leader.java:536: if
(!System.getProperty("zookeeper.leaderServes", "yes").equals("no")) {
src/java/systest/org/apache/zookeeper/test/system/BaseSysTest.java:111:
private static boolean fakeMachines =
System.getProperty("baseSysTest.fakeMachines", "no").equals("yes");
src/java/test/org/apache/zookeeper/test/ClientTest.java:57: private boolean
skipACL = System.getProperty("zookeeper.skipACL", "no").equals("yes");
{noformat}
> zookeeper.skipACL should be a boolean in addition to a yes or no
> ----------------------------------------------------------------
>
> Key: ZOOKEEPER-2403
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2403
> Project: ZooKeeper
> Issue Type: Wish
> Reporter: Ryan P
> Priority: Trivial
>
> Currently zookeeper.skipACL is evaluated to be either yes or no. This is less
> than intuitive most developers would expect this to except true or false.
> https://github.com/apache/zookeeper/blob/trunk/src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java#L96-Lundefined
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
