> On March 26, 2016, 6:49 p.m., Raul Gutierrez Segales wrote: > > ./src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java, > > line 231 > > <https://reviews.apache.org/r/25160/diff/27/?file=1315415#file1315415line231> > > > > shouldn't this be an assertion? if request is null here things went > > totally wrongn (before we'd just crash with a NullPointerException), but > > now we just retry? if it is indeed retryable, we shouldn't log this as an > > error.
We decided to only throw an exception for errors indicating an inconsistent state and for other errors just log and continue. Do you think its better to throw an exception here and in the other place Rakesh commented on ? - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25160/#review125540 ----------------------------------------------------------- On March 26, 2016, 7:06 p.m., Kfir Lev-Ari wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25160/ > ----------------------------------------------------------- > > (Updated March 26, 2016, 7:06 p.m.) > > > Review request for zookeeper, Raul Gutierrez Segales and Alexander Shraer. > > > Repository: zookeeper > > > Description > ------- > > Please see https://issues.apache.org/jira/browse/ZOOKEEPER-2024 > > > Diffs > ----- > > ./src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java > 1726708 > > ./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorConcurrencyTest.java > 1726708 > ./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorTest.java > 1726708 > > Diff: https://reviews.apache.org/r/25160/diff/ > > > Testing > ------- > > The attached unit tests, as well as the system test found in > https://issues.apache.org/jira/browse/ZOOKEEPER-2023. > > > Thanks, > > Kfir Lev-Ari > >
