[
https://issues.apache.org/jira/browse/ZOOKEEPER-2403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15250460#comment-15250460
]
Patrick Hunt commented on ZOOKEEPER-2403:
-----------------------------------------
Sounds reasonable to me. Just a couple suggestions:
1) cleanup the util code, no need to call getProperty twice from getBool afaict?
2) import the class rather than the static method. Makes it easier to follow if
the code references class.method rather than just the method.
> Consistently handle and document boolean properties (true/false as well as
> yes/no)
> ----------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-2403
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2403
> Project: ZooKeeper
> Issue Type: Wish
> Reporter: Ryan P
> Assignee: Ryan P
> Priority: Trivial
> Attachments: ZOOKEEPER-2403.patch
>
>
> Currently zookeeper.skipACL is evaluated to be either yes or no. This is less
> than intuitive most developers would expect this to except true or false.
> https://github.com/apache/zookeeper/blob/trunk/src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java#L96-Lundefined
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
