[
https://issues.apache.org/jira/browse/ZOOKEEPER-2402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15294644#comment-15294644
]
Michael Han commented on ZOOKEEPER-2402:
----------------------------------------
Thanks for the patch [~arshad.mohammad]! LGTM with some nits:
{noformat}
<para>Set false to disable SASL authentication. Default is true</para>
{noformat}
Missing full stop after 'true'. There are also a couple of other places in the
patch where full stops are missing.
{noformat}
The format of a typical Kerberos V5 principal is primary/instance@REALM.
zookeeper.sasl.client.username specifies the primary part of the ZooKeeper
Server principal.
{noformat}
How about making the 'server' bold here? Maybe something like Zookeeper
<emphasis role="bold">server</emphasis>?
{noformat}
instance part is derived from the server's IP.
{noformat}
Instance (upper case of 'I') instead of instance.
There are a few documentations are copied from admin doc to programmer doc.
According to ZOOKEEPER-2397 looks like everyone is OK with duplication. If
there is an easy way to avoid copying pasting by using links (which has its
limitations) or some other mechanism that might be ideal, but I am OK with the
copy / paste if we think explicit duplicating is better.
> Document client side properties
> -------------------------------
>
> Key: ZOOKEEPER-2402
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2402
> Project: ZooKeeper
> Issue Type: Bug
> Components: documentation
> Reporter: Arshad Mohammad
> Assignee: Arshad Mohammad
> Fix For: 3.5.2
>
> Attachments: ZOOKEEPER-2402-01.patch
>
>
> There are many ZooKeeper java client properties which are not documented.
> Bellow client properties are not documented in Admin Guide
> # zookeeper.sasl.client.username
> # zookeeper.sasl.clientconfig
> # zookeeper.sasl.client
> # zookeeper.server.realm
> # zookeeper.disableAutoWatchReset
> Bellow two client properties are documented in Admin Guide but these are
> documented in server configuration section
> # zookeeper.client.secure
> # zookeeper.clientCnxnSocket
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
