[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15311284#comment-15311284
 ] 

Patrick Hunt commented on ZOOKEEPER-2430:
-----------------------------------------

I'm sorry [~zhangyongxyz] that the original jira went missing, here's my 
original comment

This seems like a pretty obvious problem to me:

{noformat}
-        if (len < 0 || len >= packetLen) {
+        if (len < 0) {
{noformat}

Why?

Additionally iiuc this results in a non-b/w compatible situation - the max 
buffer size is effectively being reduced (in one direction). Sounds like that 
might catch people by surprise.

> Remove jute.maxbuffer limit packetLen in client side
> ----------------------------------------------------
>
>                 Key: ZOOKEEPER-2430
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2430
>             Project: ZooKeeper
>          Issue Type: Improvement
>            Reporter: Yong Zhang
>            Assignee: Yong Zhang
>         Attachments: ZOOKEEPER-2430.001.patch, ZOOKEEPER-2430.002.patch
>
>
> jute.maxbuffer can be configured in both client and server side, if we try to 
> getChildren
> from a parent znode with large number of children znode, client may failed to 
> get because
> of packetLen is more than jute.maxbuffer configured. 
> even if we can change the value in java system property, but we have to 
> restart the application,
> and more all data has been in zookeeper client, check the length/size is 
> unnecessary.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to