[
https://issues.apache.org/jira/browse/ZOOKEEPER-2137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15319497#comment-15319497
]
Michael Han edited comment on ZOOKEEPER-2137 at 6/7/16 9:44 PM:
----------------------------------------------------------------
In ZOOKEEPER-2137.patch, a delay was introduced after sync. This is not ideal
as the timing may be off and depend on runtime environment. This
ZOOKEEPER-2137-cb.patch did the fix in a different way by using a count down
latch to block main thread until the callback from sync is executed, at which
point the sync request should have been processed by server.
However, this fix does not pass my endurance tests. I am suspecting there might
be a separate issue in the watcher and/or server code, and I am looking into
it. Meanwhile, it might be good to get ZOOKEEPER-2137.patch in trunk which
survives endurance tests.
was (Author: hanm):
In ZOOKEEPER-2137.patch, a delay was introduced after sync. This is not ideal
as the timing may be off and depend on runtime environment. This patch did the
fix in a different way by using a count down latch to block main thread until
the callback from sync is executed, at which point the sync request should have
been processed by server.
However, this fix does not pass my endurance tests. I am suspecting there might
be a separate issue in the watcher and/or server code, and I am looking into
it. Meanwhile, it might be good to get ZOOKEEPER-2137.patch in trunk which
survives endurance tests.
> Make testPortChange() less flaky
> --------------------------------
>
> Key: ZOOKEEPER-2137
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2137
> Project: ZooKeeper
> Issue Type: Sub-task
> Reporter: Hongchao Deng
> Assignee: Michael Han
> Fix For: 3.5.2, 3.6.0
>
> Attachments: ZOOKEEPER-2137-cb.patch, ZOOKEEPER-2137.patch,
> ZOOKEEPER-2137.patch
>
>
> The cause of flaky failure of testPortChange() is a race in sync().
> I figured out it could take some time to fix sync(). Meanwhile, we can make
> testPortChange() less flaky by doing reconfig on the leader. We can change
> this back in the fix of ZOOKEEPER-2136.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
