[
https://issues.apache.org/jira/browse/ZOOKEEPER-1350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15343025#comment-15343025
]
Hadoop QA commented on ZOOKEEPER-1350:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12650322/ZOOKEEPER-1350-trunk.diff
against trunk revision 1748630.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
-1 patch. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3231//console
This message is automatically generated.
> Please make JMX registration optional in LearnerZooKeeperServer
> ---------------------------------------------------------------
>
> Key: ZOOKEEPER-1350
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1350
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
> Affects Versions: 3.4.0
> Reporter: Jordan Zimmerman
> Assignee: Jordan Zimmerman
> Fix For: 3.6.0, 3.5.3
>
> Attachments: ZOOKEEPER-1350-trunk.diff, ZOOKEEPER-1350.diff,
> jmx_optional.diff, patch.txt
>
>
> LearnerZooKeeperServer has no option to disable JMX registrations. Curator
> has a test ZK server cluster. Due to the intricacies of JMX, the
> registrations cannot be easily undone. In order for the Curator Test cluster
> to be re-usable in a testing session, JavaAssist ugliness was necessary to
> make LearnerZooKeeperServer.registerJMX() and
> LearnerZooKeeperServer.unregisterJMX() NOPs.
> I suggest a simple System property.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
