Chris Nauroth created ZOOKEEPER-2452:
----------------------------------------

             Summary: Back-port ZOOKEEPER-1460 to 3.4 for IPv6 literal address 
support.
                 Key: ZOOKEEPER-2452
                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2452
             Project: ZooKeeper
          Issue Type: Bug
          Components: quorum
            Reporter: Chris Nauroth
             Fix For: 3.4.9


Via code inspection, I see that the "server.nnn" configuration key does not 
support literal IPv6 addresses because the property value is split on ":". In 
v3.4.3, the problem is in QuorumPeerConfig:

{noformat}
String parts[] = value.split(":");
InetSocketAddress addr = new InetSocketAddress(parts[0],
                        Integer.parseInt(parts[1]));
{noformat}

In the current trunk 
(http://svn.apache.org/viewvc/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java?view=markup)
 this code has been refactored into QuorumPeer.QuorumServer, but the bug 
remains:

{noformat}
String serverClientParts[] = addressStr.split(";");
String serverParts[] = serverClientParts[0].split(":");
addr = new InetSocketAddress(serverParts[0],
                        Integer.parseInt(serverParts[1]));
{noformat}

This bug probably affects very few users because most will naturally use a 
hostname rather than a literal IP address. But given that IPv6 addresses are 
supported for clients via ZOOKEEPER-667 it seems that server support should be 
fixed too.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to