[
https://issues.apache.org/jira/browse/ZOOKEEPER-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15350046#comment-15350046
]
Rakesh R commented on ZOOKEEPER-1045:
-------------------------------------
Attached new patch addressing [~phunt]'s review comments. Kindly review it
again. Thanks!
Following are the major changes:-
bq. '{test.data.kerberos.dir' was created. It's probably an issue with the
build.xml?
Done.
bq. src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java:174:
closeStream(java.io.Closeable) in org.apache.zookeeper.common.IOUtils cannot be
applied to (java.net.Socket). However the code fails to compile with 1.6 - 5
warnings and 1 error IOUtils.closeStream(sock);
Done. Fixed 1 error case induced by my patch. I haven't touched other 5
warnings which already exists in the code base.
bq. should we say "client" here or "learner"? just wondering re
usability/understandability (vs a "real" zk client)
I've replaced {{quorum client}} terminology with {{quorum learner}} for better
ubderstandability. I've tried replacing all the occurances including
configurations and class names. I think this renaming has changed the code more
compare to the other review comment fixes.
Apart from all the above, this patch fixed all the review comments given in
[review ticket|https://reviews.apache.org/r/47354/]
> Support Quorum Peer mutual authentication via SASL
> --------------------------------------------------
>
> Key: ZOOKEEPER-1045
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1045
> Project: ZooKeeper
> Issue Type: New Feature
> Components: server
> Reporter: Eugene Koontz
> Assignee: Rakesh R
> Priority: Critical
> Fix For: 3.4.9, 3.5.3
>
> Attachments: 0001-ZOOKEEPER-1045-br-3-4.patch,
> 1045_failing_phunt.tar.gz, ZK-1045-test-case-failure-logs.zip,
> ZOOKEEPER-1045-00.patch, ZOOKEEPER-1045-Rolling Upgrade Design Proposal.pdf,
> ZOOKEEPER-1045-br-3-4.patch, ZOOKEEPER-1045-br-3-4.patch,
> ZOOKEEPER-1045-br-3-4.patch, ZOOKEEPER-1045-br-3-4.patch,
> ZOOKEEPER-1045-br-3-4.patch
>
>
> ZOOKEEPER-938 addresses mutual authentication between clients and servers.
> This bug, on the other hand, is for authentication among quorum peers.
> Hopefully much of the work done on SASL integration with Zookeeper for
> ZOOKEEPER-938 can be used as a foundation for this enhancement.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
