Agreed, I don't think it is a block either. We are more sensitive to licensing issues, so that's why we had to stop the RC.
Please feel free to create a jira so that we do it for the following release, Enrico. -Flavio > On 30 Jun 2016, at 06:58, Patrick Hunt <ph...@apache.org> wrote: > > Enrico, I don't believe this would be a blocker for the 3.5.2 release > (correct me if I missed something). Certainly we should fix it, but not a > blocker imo. > > Patrick > > On Wed, Jun 29, 2016 at 10:40 PM, Enrico Olivelli <eolive...@gmail.com> > wrote: > >> Hi, >> There is also the javacc dep to be removed if it is possible. I don't know >> if I have time today in order to submit a patch >> >> Enrico >> >> Il Gio 30 Giu 2016 06:19 Patrick Hunt <ph...@apache.org> ha scritto: >> >>> I've committed 2458 and 2459 to 3.5 and trunk branches if you want to cut >>> another RC. These two patches addressed the concerns raised by Flavio. >>> >>> Patrick >>> >>> On Wed, Jun 29, 2016 at 2:32 PM, Flavio Junqueira <f...@apache.org> >> wrote: >>> >>>> -1, In the last update of ZK-2235, we didn't remove >>>> servlet-api-2.5.LICENSE.txt, so the licensing information is incorrect. >>>> I'll submit a patch shortly. >>>> >>>> Since we are on the topic, I'm wondering if we need to bubble up the >>>> contents of the netty notice file as well that comes in the jar. >> Before I >>>> thought that it wasn't necessary as long as the NOTICE is there with >> the >>>> jar, but then someone in the incubator list called the attention to the >>>> fact that we needed to bubble up some info in the notice file. The >>>> instructions I'm aware of aren't super clear: >>>> >>>> http://www.apache.org/dev/licensing-howto.html#alv2-dep >>>> >>>> -Flavio >>>> >>>>> On 29 Jun 2016, at 18:34, Mohammad arshad < >> mohammad.ars...@huawei.com> >>>> wrote: >>>>> >>>>> +1 (non binding) >>>>> Built tar on windows >>>>> Generated docs >>>>> VERFICATION: >>>>> Installed 2 cluster each of 3 zk server >>>>> 1)Tested following scenario for ZOOKEEPER-2139 Multi Client in a JVM >>>> (with 2 clients from the same jvm) >>>>> i) One client connected to secure, SSL authentication enabled, >>>> cluster other to non-secure cluster >>>>> Both clients were doing create, delete, get data and set data >>>> simultaneously and continuously >>>>> ii) One client connected to kerbeors authentication enabled >>>> cluster other to digest authentication enabled cluster >>>>> Both clients were doing create, delete, get data and set data >>>> simultaneously and continuously >>>>> 2) Following Operations are verified >>>>> create node (ALL API, All node types) >>>>> delete node >>>>> set data >>>>> get data >>>>> setAcl >>>>> getAcl >>>>> multi operation >>>>> Few Four letter word commands >>>>> 3) Verified all the JIRA in which I was involved, all are passed >>>>> >>>>> Thanks, >>>>> Arshad >>>>> >>>>> -----Original Message----- >>>>> From: Patrick Hunt [mailto:ph...@apache.org] >>>>> Sent: 29 June 2016 20:47 >>>>> To: DevZooKeeper >>>>> Subject: Re: [VOTE] Apache ZooKeeper release 3.5.2-alpha candidate 0 >>>>> >>>>> Looks like that javacc dependency was added in >>>>> https://issues.apache.org/jira/browse/ZOOKEEPER-96 and should have >>> been >>>> build only afaict. >>>>> >>>>> Thanks for reporting this Enrico, would you mind submitting a JIRA >> (and >>>> perhaps a patch)? >>>>> >>>>> Thanks, >>>>> >>>>> Patrick >>>>> >>>>> >>>>> On Wed, Jun 29, 2016 at 8:10 AM, Enrico Olivelli < >> eolive...@gmail.com> >>>>> wrote: >>>>> >>>>>> +1 (non binding) >>>>>> Tested Majordodo (http://majordodo.org) and BlazingCache >>>>>> (http://blazingcache.org) against 3.5.2-alpha. >>>>>> >>>>>> My tests also include running Apache BookKeeper 4.4.0 using the >>>>>> 3.5.2-alpha java client. >>>>>> >>>>>> All is fine but dependencies changed a lot, many legacy deps like >>>>>> jline, jms and sun jmx disappeared and this is very good, >>>>>> >>>>>> but this new dependency showed up: >>>>>> net.java.dev.javacc:javacc:jar:5.0 >>>>>> >>>>>> If I exclude javacc all of my tests continue to run fine, my tests >>>>>> cover both java client and embedded single server. >>>>>> Maybe it would be useful to hide the dependency in future release >> but >>>>>> it is not a showstopper for my projects. >>>>>> >>>>>> >>>>>> >>>>>> 2016-06-28 19:52 GMT+02:00 Abraham Fine <a...@abrahamfine.com>: >>>>>>> +1 tested SSL support, everything appears to be working as >> expected. >>>>>>> >>>>>>> On Fri, Jun 24, 2016, at 03:19 PM, Patrick Hunt wrote: >>>>>>>> +1. sig/xsum are valid, RAT ran clean and no other discrepancies >>>>>> noticed. >>>>>>>> I >>>>>>>> ran it through a number of manual tests (including starting a 23 >>>>>>>> server >>>>>>>> ensemble) - no issues found. >>>>>>>> >>>>>>>> Patrick >>>>>>>> >>>>>>>> On Thu, Jun 23, 2016 at 10:33 PM, Chris Nauroth >>>>>>>> <cnaur...@hortonworks.com> >>>>>>>> wrote: >>>>>>>> >>>>>>>>> This is a release candidate for 3.5.2-alpha. The full release >>>>>>>>> notes >>>>>> are >>>>>>>>> available at: >>>>>>>>> >>>>>>>>> >>>>>> >>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310 >>>>>> 801&v >>>>>>>>> ersion=12331981 >>>>>>>>> >>>>>>>>> *** Please download, test and vote by July 1st 2016, 23:59 UTC+0. >>>>>>>>> *** >>>>>>>>> >>>>>>>>> Source files: >>>>>>>>> >> http://people.apache.org/~cnauroth/zookeeper-3.5.2-alpha-candidat >>>>>>>>> e-0/ >>>>>>>>> >>>>>>>>> Maven staging repo: >>>>>>>>> >>>>>> >>> https://repository.apache.org/content/groups/staging/org/apache/zookee >>>>>> per/z >>>>>>>>> ookeeper/3.5.2-alpha/ >>>>>>>>> >>>>>>>>> The tag to be voted upon: >>>>>>>>> >> https://svn.apache.org/repos/asf/zookeeper/tags/release-3.5.2-rc0 >>>>>>>>> / >>>>>>>>> >>>>>>>>> ZooKeeper's KEYS file containing PGP keys we use to sign the >>> release: >>>>>>>>> http://www.apache.org/dist/zookeeper/KEYS >>>>>>>>> >>>>>>>>> Should we release this candidate? >>>>>>>>> >>>>>>>>> >>>>>>>>> --Chris Nauroth >>>>>>>>> >>>>>>>>> >>>>>> >>>> >>>> >>> >> -- >> >> >> -- Enrico Olivelli >>
