+1 (non-binding) - built ZK from source - ran all the unit tests - generated and checked javadocs - generated and checked docs - executed few manual test (zkCli.sh) and 4lw
Some small issues (imho): - the copyright notice is still dating "2008-2013". It's worth updating to the current year? - I consistently ran on an test error equals to the one at https://builds.apache.org/job/ZooKeeper-trunk/2982/console - Also this one: https://mail-archives.apache.org/mod_mbox/zookeeper-dev/201601.mbox/%3C1279938263.1283.1453526737790.JavaMail.jenkins@crius%3E - In fact, there were 14 failing tests total (I suspect all of them related to the C tests). Any ideas? A couple of flacky tests? Regards, Eddie On Sat, Jul 2, 2016 at 1:46 PM, Rakesh Radhakrishnan < [email protected]> wrote: > +1 > > - built zookeeper jar from source, > - ran unit test cases, few zkCli commands, few four letter words, > - tested few scenarios against Hadoop-2.7.2 version(3 node Kerberos secure > cluster environment). > > Thanks Chris for making the release. > > Regards, > Rakesh > > On Sat, Jul 2, 2016 at 7:43 PM, Flavio Junqueira <[email protected]> wrote: > > > +1 > > > > - Checked license information > > - Ran RAT tool > > - Ran tests > > - Ran some smoke tests > > - Verified digests and signature > > - Checked release notes > > > > All of the above LGTM > > > > -Flavio > > > > > > > On 01 Jul 2016, at 08:45, Chris Nauroth <[email protected]> > > wrote: > > > > > > This is a release candidate for 3.5.2-alpha. The full release notes are > > > available at: > > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801&v > > > ersion=12331981 > > > > > > *** Please download, test and vote by July 5th 2016, 23:59 UTC+0. *** > > > > > > Source files: > > > http://people.apache.org/~cnauroth/zookeeper-3.5.2-alpha-candidate-1/ > > > > > > Maven staging repo: > > > > > > https://repository.apache.org/content/groups/staging/org/apache/zookeeper/z > > > ookeeper/3.5.2-alpha/ > > > > > > The tag to be voted upon: > > > https://svn.apache.org/repos/asf/zookeeper/tags/release-3.5.2-rc1/ > > > > > > ZooKeeper's KEYS file containing PGP keys we use to sign the release: > > > http://www.apache.org/dist/zookeeper/KEYS > > > > > > Should we release this candidate? > > > > > > > > > --Chris Nauroth > > > > > > > > > > > > > > > > >
