[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384566#comment-15384566
 ] 

Rakesh R commented on ZOOKEEPER-2477:
-------------------------------------

Thanks [~abrahamfine] for the patch. Adding few comments,

- Comment-1)
{code}
<para><computeroutput>$ bin/zkCli.sh 127.0.0.1:2181</computeroutput></para>
{code}
Here, please add {{-server}} option.

- Comment-2)
{code}
-          <para>Running either program gives you a shell in which to execute
-          simple file-system-like operations. To connect to ZooKeeper with the
-          multithreaded client, for example, you would run:</para>
{code}
Probably can retain the shell info and can rephrase like, {{This will give you 
a simple shell to execute file-like operations on ZooKeeper.}} in 
zookeeperAdmin.xml

- Comment-3)
{code}
<programlisting>bin/zkCli.sh -server 127.0.0.1:2181</programlisting>
{code}
Please include {{$}} symbol, just to make consistent everywhere
{code}
<programlisting>$ bin/zkCli.sh -server 127.0.0.1:2181</programlisting>
{code}

- Comment-4)
{code}
<para>This lets you perform simple, file-like operations.</para>
{code}
Again this also can be rephrased something like,
{code}
<para>This will give you a simple shell to execute file-like operations on 
ZooKeeper.</para>
{code}

> documentation should refer to Java cli shell and not C cli shell
> ----------------------------------------------------------------
>
>                 Key: ZOOKEEPER-2477
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2477
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: documentation
>    Affects Versions: 3.4.8, 3.5.2
>            Reporter: Patrick Hunt
>            Assignee: Abraham Fine
>              Labels: newbie
>             Fix For: 3.4.9, 3.5.3, 3.6.0
>
>         Attachments: ZOOKEEPER-2477-br3.4.patch, ZOOKEEPER-2477.patch
>
>
> The documentation tends to refer to the c cli shell when citing examples of 
> how to interact with ZK, rather than using the Java cli shell. Given the Java 
> cli is much better maintained and more featureful the docs should refer to 
> that instead. Also the c cli was originally meant to be a sample/example of c 
> client usage rather than a true cli tool.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to