[
https://issues.apache.org/jira/browse/ZOOKEEPER-2492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15398686#comment-15398686
]
Michael Han commented on ZOOKEEPER-2492:
----------------------------------------
LGTM - note the indentation seems a little bit off:
{code}
// Set log callback before calling into log_env
zh->log_callback = log_callback;
log_env(zh);
LOG_INFO(LOGCALLBACK(zh), "Initiating client connection, host=%s
sessionTimeout=%d watcher=%p" 1103 LOG_INFO(LOGCALLBACK(zh),
"Initiating client connection, host=%s sessionTimeout=%d watcher=%p"
{code}
> gethostname return error before Win32WSAStartup on windows.
> -----------------------------------------------------------
>
> Key: ZOOKEEPER-2492
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2492
> Project: ZooKeeper
> Issue Type: Bug
> Affects Versions: 3.5.2
> Environment: windows
> Reporter: spooky000
> Assignee: spooky000
> Priority: Trivial
> Fix For: 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2492.patch, ZOOKEEPER-2492.patch
>
>
> gethostname return error before Win32WSAStartup on windows.
> in log_env function.
> gethostname(buf, sizeof(buf));
> LOG_INFO(LOGCALLBACK(zh), "Client environment:host.name=%s", buf);
> buf will be uninitialized buffer.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
