[
https://issues.apache.org/jira/browse/ZOOKEEPER-2491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15398702#comment-15398702
]
Michael Han commented on ZOOKEEPER-2491:
----------------------------------------
LGTM.
One suggestion, we might want to emulate snprintf() instead of using
_snprintf() for MSVC prior to 15, because _snprintf() doesn't zero-terminate
the buffer. Something like what libuv is doing:
https://github.com/libuv/libuv/blob/9e7568ea7b2b9375be6563c9fb5e795c9753287e/test/task.h#L187-L209
> C client build error in vs 2015
> --------------------------------
>
> Key: ZOOKEEPER-2491
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2491
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.5.2
> Environment: windows vs 2015
> Reporter: spooky000
> Assignee: spooky000
> Priority: Minor
> Fix For: 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2491.patch, ZOOKEEPER-2491.patch
>
>
> Visual Studio 2015 supports snprintf.
> #define snprintf _snprintf throw error.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
