[
https://issues.apache.org/jira/browse/ZOOKEEPER-2285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15400002#comment-15400002
]
Michael Han commented on ZOOKEEPER-2285:
----------------------------------------
For the completeness's sake, copy the discussion from dev-list to here for the
record..
{noformat}
- The skipped test does not cause a build failure. In fact, this same test has
been skipped for the past 70+ pre-commit builds, among which there are a couple
of succeeded ones [1].
- The failure of this pre-commit build (3302) is caused by build.xml:1605,
according to Jenkins. It is not obvious to me what failed from the log though.
Will dig deeper.
https://github.com/apache/zookeeper/blob/trunk/build.xml#L1605
Regarding the skipped test, it's QuorumTest::testSessionMove
https://github.com/apache/zookeeper/blob/trunk/src/java/test/org/apache/zookeeper/test/QuorumTest.java#L253
This test (along with some others in QuorumTest) is ignored in
https://issues.apache.org/jira/browse/ZOOKEEPER-733, because "session moved
tests are currently ignored since they fail in netty. ". Then later, in
https://issues.apache.org/jira/browse/ZOOKEEPER-907, all other ignored tests
were activated, but not this one with no particular reason. I assume that just
an overlook..
Also there is an existing JIRA about this skipped test, we should probably
un-skip this test as it's legitimate.
https://issues.apache.org/jira/browse/ZOOKEEPER-2285
[1] Succeeded pre-commit build with testSessionMove test skipped:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3308/
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3290/
{noformat}
> QuorumTest's ignored test case causes wrong CI pre-commit feedback
> ------------------------------------------------------------------
>
> Key: ZOOKEEPER-2285
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2285
> Project: ZooKeeper
> Issue Type: Bug
> Components: tests
> Affects Versions: 3.5.0
> Reporter: Arshad Mohammad
> Assignee: Arshad Mohammad
> Fix For: 3.5.3
>
> Attachments: ZOOKEEPER-2285-01.patch
>
>
> # test case {{org.apache.zookeeper.test.QuorumTest.testSessionMove()}} is
> marked ignored by ZOOKEEPER-907
> # Most of the CI pre-commit feedback is -1 because of above ignored test case.
> # Test case is locally passing
> The ignore tag should be removed from testSessionMove test case.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
