[jira] [Commented] (ZOOKEEPER-2503) Inconsistency between myid documentation and implementation

[Flavio Junqueira (JIRA)]

    [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15410608#comment-15410608
 ] 

Flavio Junqueira commented on ZOOKEEPER-2503:
---------------------------------------------

We require it in the processing of session ids, here are the two references I 
got:

{noformat}
    nextSessionId = SessionTrackerImpl.initializeNextSession(this.serverId);

    public static long initializeNextSession(long id) {
        long nextSid = 0;
        nextSid = (System.currentTimeMillis() << 24) >>> 8;
        nextSid =  nextSid | (id <<56);
        return nextSid;
    }
{noformat}


and in LeaderSessionTracker:

{noformat}
    // Returns the serverId from the sessionId (the high order byte)
    public static long getServerIdFromSessionId(long sessionId) {
        return sessionId >> 56;
    }
{noformat}

I couldn't find it anywhere else. 

> Inconsistency between myid documentation and implementation
> -----------------------------------------------------------
>
>                 Key: ZOOKEEPER-2503
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2503
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: server
>    Affects Versions: 3.4.9, 3.5.2
>            Reporter: Michael Han
>             Fix For: 3.5.3, 3.4.10
>
>
> In ZK documentation, we have:
> "The myid file consists of a single line containing only the text of that 
> machine's id. So myid of server 1 would contain the text "1" and nothing 
> else. The id must be unique within the ensemble and should have a value 
> between 1 and 255."
> This however is not enforced in code, which should be fixed either in 
> documentation that we remove the restriction of the range 1-255 or in code we 
> enforce such constraint.
> Discussion thread:
> http://zookeeper-user.578899.n2.nabble.com/Is-myid-actually-limited-to-1-255-td7581270.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)