[
https://issues.apache.org/jira/browse/ZOOKEEPER-2508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15414733#comment-15414733
]
Raul Gutierrez Segales commented on ZOOKEEPER-2508:
---------------------------------------------------
Sweet patch, thanks [~arshad.mohammad]!
A few nits:
In:
{code}
+public class PurgeTxnTest extends ZKTestCase{
{code}
a space is missing before the {
In:
{code}
+ zk[i] = ClientBase.createZKClient("127.0.0.1:" + clientPorts[i]);
{code}
extra whitespace after the =
Ditto in:
{code}
+ ZooKeeper zk = ClientBase.createZKClient(HOSTPORT);
{code}
Missing whitespace before the { in:
{code}
+public class LoadFromLogTest extends ZKTestCase{
{code}
Ditto for:
{code}
+public class SledgeHammer extends Thread{
{code}
Extra whitespace in:
{code}
+ zk = ClientBase.createZKClient("127.0.0.1:" + port2, 15000);
+
{code}
Other than that, it looks great. +1.
> Many ZooKeeper tests are flaky because they proceed with zk operation without
> connecting to ZooKeeper server.
> -------------------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-2508
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2508
> Project: ZooKeeper
> Issue Type: Bug
> Components: tests
> Reporter: Arshad Mohammad
> Assignee: Arshad Mohammad
> Fix For: 3.5.3
>
> Attachments: ZOOKEEPER-2508-01.patch, ZOOKEEPER-2508-02.patch,
> ZOOKEEPER-2508-03.patch, ZOOKEEPER-2508-04.patch, ZOOKEEPER-2508-05.patch
>
>
> Many ZooKeeper tests are flaky because they proceed with zk operation without
> connecting to ZooKeeper server.
> Recently in our build
> {{org.apache.zookeeper.server.ZooKeeperServerMainTest.testStandalone()}}
> failed.
> After analyzing we found that it is failed because it is not waiting for
> ZooKeeper client get connected to server. In this case normally zookeeper
> client gets connected immediately but if not connected immediately the test
> case is bound to fail.
> Not only ZooKeeperServerMainTest but there are many other classes which have
> such test cases. This jira is to address all those test cases.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
