[
https://issues.apache.org/jira/browse/ZOOKEEPER-2489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15415662#comment-15415662
]
Michael Han commented on ZOOKEEPER-2489:
----------------------------------------
Thanks [~eribeiro] for the patch!
{code}
public static final int DEFAULT_IDLE_TIMEOUT = 30000;
{code}
Should we make this a configurable parameter as well? The existing 'DEFAULT_*'
parameters are configurable via system properties:
{code}
public JettyAdminServer() throws AdminServerException {
this(System.getProperty("zookeeper.admin.serverAddress",
DEFAULT_ADDRESS), Integer.getInteger(
"zookeeper.admin.serverPort", DEFAULT_PORT), System
.getProperty("zookeeper.admin.commandURL",
DEFAULT_COMMAND_URL));
}
{code}
If we do this, then the documentation needs to be updated as well.
Other than this patch lgtm.
> Upgrade Jetty dependency to a recent stable release version.
> ------------------------------------------------------------
>
> Key: ZOOKEEPER-2489
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2489
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
> Affects Versions: 3.4.8, 3.5.2
> Reporter: Michael Han
> Assignee: Edward Ribeiro
> Fix For: 3.5.3
>
> Attachments: ZOOKEEPER-2489.2.patch, ZOOKEEPER-2489.patch
>
>
> Jetty was added as one of dependencies in ZOOKEEPER-1346 in 2011, and have
> not been updated since then. The version we are using in trunk is 6.1.26
> which was released in 2010. We should consider upgrade Jetty to a recent
> stable release version (probably one of the 9.x.).
> Note: this JIRA issue is recreated from
> https://issues.apache.org/jira/browse/ZOOKEEPER-2427, which was deleted a
> couple of weeks ago as part of Apache Infrastructure spam fighting effort.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
