Unfortunately, I don’t think it’s possible for the current ZooKeeper test-patch.sh to work with a binary file. If we eventually migrate to Apache Yetus, then its version of pre-commit has the capability to run “git apply”, which can handle binary diffs generated by “git diff”.
For ZOOKEEPER-1260, I think you’ll need to work through pre-commit by attaching an alternative version of the patch that omits the binary file. (It’s a JPEG for the docs, so omitting the file won’t harm test results.) --Chris Nauroth On 8/16/16, 1:29 AM, "Mohammad arshad" <[email protected]> wrote: Hello everyone In ZooKeeper pre-commit patch apply has failed for the patch ZOOKEEPER-1260-01.patch. This patch applies on trunk locally ZOOKEEPER-1260-01.patch contains a binary file. This patch is generated with "git diff --no-prefix --binary HEAD > ZOOKEEPER-1260-01.patch" command I think the binary file, in the patch, is the reason for failure in CI. any idea on how to give patch in zookeeper which has binary file? Thanks -Arshad
