OK, I'll do necessary steps again and come up with rc1, thanks. Rakesh
On Tue, Aug 23, 2016 at 12:20 AM, Chris Nauroth <cnaur...@hortonworks.com> wrote: > Rakesh, thank you for figuring this out. Lack of running the "test" > target would explain this. > > IMO, you will need to tag again, because the RC number is part of the tag. > > Also, I don’t believe you can skip step 8 under Building. Even though > code hasn’t changed, there are still reasons that the rebuilt jar file can > be different from what you staged into Nexus the first time, due to things > like file timestamps. We want the artifact in the tarball to match the > artifact in Nexus, so I think it’s safer to repeat step 8 for this RC. > > --Chris Nauroth > > On 8/22/16, 11:39 AM, "Rakesh Radhakrishnan" <rakeshr.apa...@gmail.com> > wrote: > > IIUC, you are advising me to skip the 8th step in the Building section > and > just do 1, 2, 3, 4, 5, 6, 7 and 9, am I correct? Also, tagging step > is not > required, 11th step. > > Thanks, > Rakesh > > On Mon, Aug 22, 2016 at 11:50 PM, Patrick Hunt <ph...@apache.org> > wrote: > > > You'll need to go through all the "how to release" steps again (the > build > > steps, not the branching, etc...) and create an "rc1" for review. > Don't try > > to massage the jars/tars/etc... just re-run the process to create the > > .tar.gz and start a new voting thread. > > > > Patrick > > > > On Mon, Aug 22, 2016 at 11:14 AM, Rakesh Radhakrishnan < > > rakeshr.apa...@gmail.com> wrote: > > > > > I faced couple of issues in my local env while preparing the > release and > > > done two time svn checkouts. Unfortunately, I had created the > tarball > > from > > > my second one without invoking "test" target and just did $ant > package > > > tar, which has created this issue. > > > > > > rakesh@rakesh-Inspiron-3543:~/Rakesh/branch-3.4/src/c$ autoreconf > > > --version > > > autoreconf (GNU Autoconf) 2.69 > > > > > > Now, I've built "ant test package tar" in my checkout branch, it > has > > > created the tarball perfectly with all these missing files. > > > > > > Rakesh > > > > > > On Mon, Aug 22, 2016 at 10:31 PM, Patrick Hunt <ph...@apache.org> > wrote: > > > > > > > Rakesh - part of running step 1 of the "building" (ant test > package > > tar) > > > is > > > > that you should end up with (notice this is in the build > directory): > > > > > > > > phunt@phunt-MBP13:~/dev/zookeeper-br34[branch-3.4]$ ls > > > > build/zookeeper-3.4.9/src/c/ > > > > ChangeLog NOTICE.txt c-doc.Doxyfile configure.ac > missing > > > > Cli.vcproj README compile depcomp src/ > > > > INSTALL acinclude.m4 config.guess generated/ tests/ > > > > LICENSE aclocal.m4 config.h.in include/ > zookeeper.sln > > > > Makefile.am aminclude.am config.sub install-sh > > > > zookeeper.vcproj > > > > Makefile.in autom4te.cache/ configure ltmain.sh > > > > > > > > and those files should make it into the release artifact .tar.gz > > > > > > > > Is that not happening for you? > > > > > > > > what version of autotools do you have? I have: > > > > > > > > phunt@phunt-MBP13:~/dev/zookeeper-br34[branch-3.4]$ autoreconf > > --version > > > > autoreconf (GNU Autoconf) 2.69 > > > > > > > > Patrick > > > > > > > > > > > > On Mon, Aug 22, 2016 at 2:25 AM, Rakesh Radhakrishnan < > > > rake...@apache.org> > > > > wrote: > > > > > > > > > Thanks Chris, Michael for the observations and advice. > > > > > > > > > > Yes, I also feel that the problem is due to missing > 'install-sh' in > > the > > > > > tarball. > > > > > > > > > > I've compared 3.4.9 tarball with previous version and found the > > > following > > > > > files are missing in "http://people.apache.org/~rak > > > > > eshr/zookeeper-3.4.9-candidate-0/zookeeper-3.4.9.tar.gz" > > > > > > > > > > $ZK_HOME/src/c/tests > > > > > compile > > > > > config.guess > > > > > config.h.in > > > > > config.sub > > > > > depcomp > > > > > install-sh > > > > > Makefile.in > > > > > missing > > > > > > > > > > Since there is no code changes to resolve this, how about > replace > > only > > > > > existing release artifacts(tarball, other files) in my public > shared > > > > > location by including these files and keeps other items as it > is > > > (Source > > > > > files, Maven staging repo, tag) ? Its just a suggestion, I > agree to > > > > follow > > > > > the standard procedures to handle this situation. > > > > > > > > > > --Rakesh > > > > > > > > > > On Mon, Aug 22, 2016 at 10:21 AM, Chris Nauroth < > > > > cnaur...@hortonworks.com> > > > > > wrote: > > > > > > > > > > > I was able to make it work by running: > > > > > > > > > > > > libtoolize --force > > > > > > aclocal > > > > > > autoheader > > > > > > automake --force-missing --add-missing > > > > > > autoconf > > > > > > > > > > > > I’ve never had to do this for prior releases though. This > is the > > > same > > > > VM > > > > > > I’ve used repeatedly for ZooKeeper release verification. > It’s > > > > > CentOS 7 > > > > > > and autoconf 2.69. > > > > > > > > > > > > The core of the issue seems to be that install-sh is not > present in > > > > this > > > > > > tarball, even though that file was present in earlier release > > > tarballs. > > > > > > The autoreconf command triggered by our build doesn’t seem to > > > > regenerate > > > > > it > > > > > > for me. Running the automake command above forces it into > place by > > > > > > symlinking to a locally installed copy. > > > > > > > > > > > > I’ll proceed with more validation of the release tomorrow. > I’ll > > > > consider > > > > > > changing my vote if it turns out there is no user-facing > impact. > > > > Still, > > > > > I > > > > > > wonder why this particular release behaves differently. > > > > > > > > > > > > --Chris Nauroth > > > > > > > > > > > > On 8/21/16, 12:57 PM, "Michael Han" <h...@cloudera.com> > wrote: > > > > > > > > > > > > Hi Chris, > > > > > > > > > > > > I don't see the error you got. All C tests passed on > Ubuntu, > > and > > > > all > > > > > > configuration and compilation stage passed on OSX (on > mac the > > > > linker > > > > > > error > > > > > > is a known issue.). What I did: > > > > > > > > > > > > * curl -O > > > > > > http://people.apache.org/~rakeshr/zookeeper-3.4.9- > candidate- > > > > > > 0/zookeeper-3.4.9.tar.gz > > > > > > * tar -xvzf zookeeper-3.4.9.tar.gz > > > > > > * cd zookeeper-3.4.9 > > > > > > * ant clean test-core-cppunit > > > > > > > > > > > > The error you got seems not so uncommon - this might > help: > > > > > > http://blog.gaku.net/autoconf/ > > > > > > > > > > > > > > > > > > On Sun, Aug 21, 2016 at 11:05 AM, Chris Nauroth < > > > > > > cnaur...@hortonworks.com> > > > > > > wrote: > > > > > > > > > > > > > -1 (binding) > > > > > > > > > > > > > > I haven't been able to run "ant clean > test-core-cppunit" to > > > build > > > > > the > > > > > > > native code and run tests. It fails in the > > > > > > "create-cppunit-configure" > > > > > > > target with the error shown below. > > > > > > > > > > > > > > My first theory was that something had gone wrong in > my own > > > build > > > > > > > environment, but I've confirmed that I can run "ant > clean > > > > > > > test-core-cppunit" for the 3.4.8 release tarball and > also > > for a > > > > git > > > > > > > checkout of branch-3.4. That leads me to conclude that > > > something > > > > > is > > > > > > wrong > > > > > > > in the 3.4.9 release tarball and not my environment. > > > > > > > > > > > > > > I'd appreciate if someone else could try it and report > their > > > > > results. > > > > > > > > > > > > > > > > > > > > > > > > > > > > create-cppunit-configure: > > > > > > > [mkdir] Created dir: /home/cnauroth/zookeeper-3.4. > > > > > > > 9/build/test/test-cppunit > > > > > > > [exec] checking for doxygen... no > > > > > > > [exec] checking for perl... /usr/bin/perl > > > > > > > [exec] checking for dot... no > > > > > > > [exec] configure: error: cannot find install-sh, > > > install.sh, > > > > > or > > > > > > > shtool in "/home/cnauroth/zookeeper-3.4.9/src/c" > > > > > > > "/home/cnauroth/zookeeper-3.4.9/src/c/.." > > > > > > "/home/cnauroth/zookeeper-3.4. > > > > > > > 9/src/c/../.." > > > > > > > > > > > > > > --Chris Nauroth > > > > > > > > > > > > > > On 8/18/16, 9:24 AM, "Rakesh Radhakrishnan" < > > > rake...@apache.org> > > > > > > wrote: > > > > > > > > > > > > > > This is a bugfix release candidate for 3.4.9. It > fixes 21 > > > > > issues, > > > > > > > including > > > > > > > issues that affect ACL cache > > > > > > > in DataTree never removes entries, prevent > multiple init > > of > > > > > login > > > > > > > object in > > > > > > > each ZKSaslClient instance, > > > > > > > ZK service becomes unavailable when leader fails > to write > > > > > > transaction > > > > > > > log, > > > > > > > upgrade netty version due > > > > > > > to security vulnerability (CVE-2014-3488) and > others. > > > > > > > > > > > > > > The full release notes are available at: > > > > > > > > > > > > > > https://issues.apache.org/ > jira/secure/ReleaseNote.jspa? > > > > > > > projectId=12310801&version=12334700 > > > > > > > > > > > > > > *** Please download, test and vote by August 26th > 2016, > > > 23:59 > > > > > > UTC+0. > > > > > > > *** > > > > > > > > > > > > > > Source files: > > > > > > > http://people.apache.org/~rakeshr/zookeeper-3.4.9- > > > > candidate-0 > > > > > > > > > > > > > > Maven staging repo: > > > > > > > https://repository.apache.org/ > > content/groups/staging/org/ > > > > > > > apache/zookeeper/zookeeper/3.4.9 > > > > > > > > > > > > > > The tag to be voted upon: > > > > > > > https://svn.apache.org/repos/ > > > asf/zookeeper/tags/release-3.4 > > > > > > .9-rc0 > > > > > > > > > > > > > > ZooKeeper's KEYS file containing PGP keys we use > to sign > > > the > > > > > > release: > > > > > > > http://www.apache.org/dist/zookeeper/KEYS > > > > > > > > > > > > > > Should we release this candidate? > > > > > > > > > > > > > > > > > > > > > Rakesh > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > Cheers > > > > > > Michael. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >
