[
https://issues.apache.org/jira/browse/ZOOKEEPER-2547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15477514#comment-15477514
]
Edward Ribeiro commented on ZOOKEEPER-2547:
-------------------------------------------
{quote}
I think the diamond operator is only for saving few key strokes. is there any
other advantage?
{quote}
To modernize the code base. ;) But that's okay to leave as it is, no problem at
all.
{quote}
We are running the server on 127.0.0.1. The result of
InetAddress.getLocalHost().getAddress().toString() will be different in
different environment. So can not use
InetAddress.getLocalHost().getAddress().toString()
{quote}
Yup, you right. In fact, I should have suggested to use
{{InetAddress.getLoopbackAddress().getAddress().toString()}}, but, again, we
can leave this as it is.
{quote}
The added test case is testing both Netty and NIO.
NIO passes before and after the fix
Netty fails before the fix but passed after the fix.
{quote}
Yes, I saw that. My original recommendation was to add another tests to check
if the znode creation *fails* when a different IP address is set up in the ACL
(say, "192.0.0.1"). The current test checks if the loopback address can create
(a "positive" test), but *maybe* a negative test can be worth. I don't know.
> IP ACL is not working with NettyServerCnxnFactory
> -------------------------------------------------
>
> Key: ZOOKEEPER-2547
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2547
> Project: ZooKeeper
> Issue Type: Bug
> Affects Versions: 3.5.0
> Reporter: Arshad Mohammad
> Assignee: Arshad Mohammad
> Fix For: 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2547-01.patch
>
>
> IP based ACL is not working with NettyServerCnxnFactory.
> Scenario:
> 1) Configure serverCnxnFactory=
> org.apache.zookeeper.server.NettyServerCnxnFactory and start ZooKeeper server
> 2) Create a znode "/n" with ACL(ZooDefs.Perms.ALL, new Id("ip",
> "127.0.0.1/8")
> 3) Create child node /n/n1. Child node creation fails.
> But the same above scenario works with NIOServerCnxnFactory
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
