[
https://issues.apache.org/jira/browse/ZOOKEEPER-2579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Edward Ribeiro updated ZOOKEEPER-2579:
--------------------------------------
Attachment: FileTxnSnapLogTest.java
Hey [~abrahamfine],
Nice patch. We badly deserve to exercise as much of the {{FileTxnSnapLog}} as
possible. It has been in the root of some annoying bugs that impact its
reliability. Thanks! :)
By the way, are you really sure you want to incur the burden of starting up a
ZK instance to test an exception, using a brittle test assertion (if I
understood correctly the test will pass if the server doesn't start up on time,
right?), when you can just write a simpler unit test to exercise this specific
part? See my attachment for ideas of how you can test your patch.
Cheers!
> ZooKeeper server should verify that dataDir and snapDir are writeable before
> starting
> -------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-2579
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2579
> Project: ZooKeeper
> Issue Type: Bug
> Affects Versions: 3.4.9, 3.5.2
> Reporter: Abraham Fine
> Assignee: Abraham Fine
> Fix For: 3.4.10, 3.5.3
>
> Attachments: FileTxnSnapLogTest.java, ZOOKEEPER-2579.patch,
> ZOOKEEPER-2579_3.4.patch
>
>
> If the directories specified for the dataDir or the snapDir are not
> writeable, the server does not fail until it actually tries to write there.
> It should fail when it starts.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
