[
https://issues.apache.org/jira/browse/ZOOKEEPER-2509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15495067#comment-15495067
]
Hadoop QA commented on ZOOKEEPER-2509:
--------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12828777/ZOOKEEPER-2509-1.patch
against trunk revision b2a484cfe743116d2531fe5d1e1d78b3960c511e.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 2 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3433//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3433//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3433//console
This message is automatically generated.
> Secure mode leaks memory
> ------------------------
>
> Key: ZOOKEEPER-2509
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2509
> Project: ZooKeeper
> Issue Type: Bug
> Affects Versions: 3.5.1, 3.5.2
> Reporter: Ted Dunning
> Assignee: Ted Dunning
> Fix For: 3.5.3, 3.6.0
>
> Attachments:
> 0001-Updated-patch-for-Netty-leak-testing-to-trunk.patch,
> ZOOKEEPER-2509-1.patch, ZOOKEEPER-2509.patch, ZOOKEEPER-2509.patch,
> ZOOKPEEPER-2509.patch, leak-patch.patch
>
>
> The Netty connection handling logic fails to clean up watches on connection
> close. This causes memory to leak.
> I will have a repro script available soon and a fix. I am not sure how to
> build a unit test since we would need to build an entire server and generate
> keys and such. Advice on that appreciated.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
