[
https://issues.apache.org/jira/browse/ZOOKEEPER-2597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15510259#comment-15510259
]
Edward Ribeiro commented on ZOOKEEPER-2597:
-------------------------------------------
Hi [~phunt],
I updated the left over kafka reference (it was a comment). My grep finds
didn't bring anymore, but let me know if there's yet another one. I have been
working with Python for just about a year now, so I would *really* appreciate
any review/feedback on this script. Thanks!
AFAIK (mostly from reading the code for it), this tool is used to have Github
PRs mergeed into Apache git repo and then the PR is closed on Github side
(updating the JIRA, etc). Committers can either use this tool or merge the
patch directly on Apache repo, it seems.
{quote}
What documents should I look at re using/workflow for this tool? Is there a
particular page(s) from Kafka that we will need to incorporate into our
docs/workflow?
{quote}
The following docs provide an sneak peak into their process.
https://cwiki.apache.org/confluence/display/KAFKA/Patch+submission+and+review
https://cwiki.apache.org/confluence/display/KAFKA/Merging+Github+Pull+Requests
https://cwiki.apache.org/confluence/display/KAFKA/Manual+Commit+Workflow
https://cwiki.apache.org/confluence/display/KAFKA/Contributing+Code+Changes
{quote}
What are they and who will be responsible for updating (assuming it's cwiki?)
{quote}
Idk if I have access, but I can update the cwiki if this tool is incorporated.
{quote}
Also, where will this tool be made available? Is it committed to git (if so
where) or is it a d/l'able for committers, available from the cwiki workflow
page... ?
{quote}
Very good question. Kafka project has it on the root folder
https://github.com/apache/kafka/blob/trunk/kafka-merge-pr.py , but I myself
would prefer to have it downloadable elsewhere...
Further references as discussed in the mailing list:
Blogs from Infra:
https://blogs.apache.org/infra/entry/github_pull_request_builds_now
https://blogs.apache.org/infra/entry/improved_integration_between_apache_and
> Add script to merge PR from Apache git repo to Github
> -----------------------------------------------------
>
> Key: ZOOKEEPER-2597
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2597
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: Edward Ribeiro
> Assignee: Edward Ribeiro
> Priority: Minor
> Attachments: ZOOKEEPER-2597.patch
>
>
> A port of kafka-merge-pr.py to workon on ZooKeeper repo.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
