Hadoop QA commented on ZOOKEEPER-2519:

-1 overall.  Here are the results of testing the latest attachment 
  against trunk revision ec20c5434cc8a334b3fd25e27d26dccf4793c8f3.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified 
                        Please justify why no new tests are needed for this 
                        Also please list what manual steps were performed to 
verify this patch.

    -1 patch.  The patch command could not apply the patch.

Console output: 

This message is automatically generated.

> zh->state should not be 0 while handle is active
> ------------------------------------------------
>                 Key: ZOOKEEPER-2519
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2519
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: c client
>    Affects Versions: 3.4.6
>            Reporter: Andrew Grasso
>            Assignee: Andrew Grasso
>         Attachments: ZOOKEEPER-2519.patch, ZOOKEEPER-2519.patch
> 0 does not correspond to any of the defined states for the zookeeper handle, 
> so a client should not expect to see this value. But in the function 
> {{handle_error}}, we set {{zh->state = 0}}, which a client may then see. 
> Instead, we should set our state to be {{ZOO_CONNECTING_STATE}}. 
> At some point the code moved away from 0 as a valid state and introduced the 
> defined states. This broke the fix to ZOOKEEPER-800, which checks if state is 
> 0 to know if the handle has been created but has not yet connected. We now 
> use {{ZOO_NOTCONNECTED_STATE}} to mean this, so the check for this in 
> {{zoo_add_auth}} must be changed.
> We saw this error in 3.4.6, but I believe it remains present in trunk.

This message was sent by Atlassian JIRA

Reply via email to