-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51546/
-----------------------------------------------------------
(Updated Oct. 3, 2016, 11:52 p.m.)
Review request for zookeeper, fpj, Patrick Hunt, Raul Gutierrez Segales, and
Alexander Shraer.
Changes
-------
Update patch that fixes a couple of places pointed by Flavio:
- Add test case to test reconfig should fail when server does not have the
super user's password configured.
- A couple of documentation updates.
- Misc small fixes and clean ups (naming, remove debug code, etc.).
Bugs: ZOOKEEPER-2014
https://issues.apache.org/jira/browse/ZOOKEEPER-2014
Repository: zookeeper-git
Description
-------
Address various security concerns around reconfig feature (ZOOKEEPER-2014) to
unblock 3.5.3 release.
Diffs (updated)
-----
build.xml 96c9ef8
src/c/include/zookeeper.h 18a203d
src/c/tests/TestReconfigServer.cc 6a429ac
src/c/tests/ZooKeeperQuorumServer.h aa8b7cc
src/c/tests/ZooKeeperQuorumServer.cc 23392cd
src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml f729095
src/docs/src/documentation/content/xdocs/zookeeperReconfig.xml 7168a01
src/java/main/org/apache/zookeeper/ClientCnxn.java 12dd51c
src/java/main/org/apache/zookeeper/KeeperException.java a05f1ab
src/java/main/org/apache/zookeeper/ZooKeeper.java f2ec3d7
src/java/main/org/apache/zookeeper/ZooKeeperMain.java 25d61a4
src/java/main/org/apache/zookeeper/admin/ZooKeeperAdmin.java PRE-CREATION
src/java/main/org/apache/zookeeper/cli/CliCommand.java 3d0a90b
src/java/main/org/apache/zookeeper/cli/ReconfigCommand.java deb7914
src/java/main/org/apache/zookeeper/server/DataTree.java 06c80d3
src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java 33f638d
src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java
e772fa8
src/java/test/org/apache/zookeeper/server/DataTreeTest.java d726643
src/java/test/org/apache/zookeeper/server/quorum/ReconfigBackupTest.java
241af52
src/java/test/org/apache/zookeeper/server/quorum/ReconfigDuringLeaderSyncTest.java
301837d
src/java/test/org/apache/zookeeper/server/quorum/ReconfigFailureCasesTest.java
e7147b3
src/java/test/org/apache/zookeeper/server/quorum/ReconfigLegacyTest.java
ee9f2e2
src/java/test/org/apache/zookeeper/server/quorum/StandaloneDisabledTest.java
1f6ce1f
src/java/test/org/apache/zookeeper/test/ACLTest.java 9920fc4
src/java/test/org/apache/zookeeper/test/ReconfigExceptionTest.java
PRE-CREATION
src/java/test/org/apache/zookeeper/test/ReconfigMisconfigTest.java
PRE-CREATION
src/java/test/org/apache/zookeeper/test/ReconfigTest.java 248a754
src/java/test/org/apache/zookeeper/test/StandaloneTest.java 5c95280
Diff: https://reviews.apache.org/r/51546/diff/
Testing
-------
Added new Java unit tests that cover various exception cases of using reconfig
API without proper set up.
All existing tests (Java and C) passed under stress tests (minors those known
flaky tests.).
Manuelly tested reconfig commands using ZooKeeper command line tool.
Thanks,
Michael Han
