[
https://issues.apache.org/jira/browse/ZOOKEEPER-2467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15557916#comment-15557916
]
Flavio Junqueira commented on ZOOKEEPER-2467:
---------------------------------------------
bq. //ZOOKEEPER-2587/ZOOKEEPER-2467 : Not handled negative scenario for redo
command
Refer only to ZOOKEEPER-2467, please. Also, say instead something like "Testing
negative number for redo command".
bq. catch(Exception e)
Don't catch an exception generically, only the one you're testing for and let
the others bubble up if any.
Indentation and formating in general are broken, please review it.
> NullPointerException when redo Command is passed negative value
> ---------------------------------------------------------------
>
> Key: ZOOKEEPER-2467
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2467
> Project: ZooKeeper
> Issue Type: Bug
> Components: java client
> Affects Versions: 3.4.8, 3.5.2
> Environment: Linux , windows
> Reporter: Joshi Shankar
> Assignee: Rakesh Kumar Singh
> Priority: Minor
> Fix For: 3.4.10, 3.5.3
>
> Attachments: ZOOKEEPER-2467-1.patch, ZOOKEEPER-2467-final.patch,
> ZOOKEEPER-2467.patch, ZOOKEEPER-2467.patch, ZOOKEEPER-2467.patch
>
>
> When negative value of argument is passed to redo command .
> [zk: localhost:2181(CONNECTED) 0] redo -1
> Exception in thread "main" java.lang.NullPointerException
> at java.util.StringTokenizer.<init>(Unknown Source)
> at java.util.StringTokenizer.<init>(Unknown Source)
> at
> org.apache.zookeeper.ZooKeeperMain$MyCommandOptions.parseCommand(ZooKeeperMain.java:227)
> at
> org.apache.zookeeper.ZooKeeperMain.processZKCmd(ZooKeeperMain.java:645)
> at
> org.apache.zookeeper.ZooKeeperMain.processCmd(ZooKeeperMain.java:588)
> at
> org.apache.zookeeper.ZooKeeperMain.executeLine(ZooKeeperMain.java:360)
> at org.apache.zookeeper.ZooKeeperMain.run(ZooKeeperMain.java:323)
> at org.apache.zookeeper.ZooKeeperMain.main(ZooKeeperMain.java:282)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
