[ https://issues.apache.org/jira/browse/ZOOKEEPER-2556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15607877#comment-15607877 ]
Hadoop QA commented on ZOOKEEPER-2556: -------------------------------------- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12835288/ZOOKEEPER-2556.patch against trunk revision f6349d16fcd5f04b560095417fd2a1813ac3e855. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3501//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3501//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3501//console This message is automatically generated. > peerType remains as "observer" in zoo.cfg even though we change the node from > observer to participant runtime > ------------------------------------------------------------------------------------------------------------- > > Key: ZOOKEEPER-2556 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2556 > Project: ZooKeeper > Issue Type: Bug > Components: server > Affects Versions: 3.5.1, 3.5.2 > Reporter: Rakesh Kumar Singh > Assignee: Rakesh Kumar Singh > Priority: Minor > Attachments: ZOOKEEPER-2556.patch, ZOOKEEPER-2556.patch, > ZOOKEEPER-2556.patch > > > peerType remains as "observer" in zoo.cfg even though we change the node from > observer to participant runtime > Steps to reproduce:- > 1. Start zookeeper in cluster with one node as observer by configuring > peerType=observer in zoo.cfg and server.2=10.18.219.50:2888:3888:observer;2181 > 2. Start the cluster > 3. start a client and change the node from observer to participant, the > configuration related to peertype remained same though other things like > clientport got from zoo.cfg > >reconfig -remove 2 -add 2=10.18.219.50:2888:3888:participant;2181 > We should either remove this parameter or update with correct node type at > run time -- This message was sent by Atlassian JIRA (v6.3.4#6332)