[
https://issues.apache.org/jira/browse/ZOOKEEPER-2622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15614872#comment-15614872
]
ASF GitHub Bot commented on ZOOKEEPER-2622:
-------------------------------------------
GitHub user fpj opened a pull request:
https://github.com/apache/zookeeper/pull/95
ZOOKEEPER-2622: ZooTrace.logQuorumPacket does nothing
DO NOT MERGE
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/fpj/zookeeper ZK-2622
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zookeeper/pull/95.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #95
----
commit 76681a075e045107f149e5ab67756991faf1d8ba
Author: fpj <f...@apache.org>
Date: 2016-10-28T09:14:51Z
ZOOKEEPER-2622: ZooTrace.logQuorumPacket does nothing
----
> ZooTrace.logQuorumPacket does nothing
> -------------------------------------
>
> Key: ZOOKEEPER-2622
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2622
> Project: ZooKeeper
> Issue Type: Bug
> Reporter: Flavio Junqueira
> Priority: Trivial
> Labels: newbie
> Fix For: 3.5.3, 3.6.0
>
>
> The method simply returns and there is some code commented out:
> {code}
> // if (isTraceEnabled(log, mask)) {
> // logTraceMessage(LOG, mask, direction + " "
> // + FollowerHandler.packetToString(qp));
> // }
> {code}
> There are calls to this trace method, so I think we should fix it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
